[iOS] - Fix URL-Bar LTR-RTL Clipping #26360
Open
+348
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brandon-T
added
CI/skip-android
Comment on lines
73
to
74
| .environment(\.layoutDirection, .leftToRight) | ||
| .flipsForRightToLeftLayoutDirection(false) |
There was a problem hiding this comment.
These are better put in URLElidedText directly since you'd probably want it anywhere its used
There was a problem hiding this comment.
You're right. Fixed.
Comment on lines
579
to
580
| textSize = attributedText?.size() ?? .zero | ||
| textSize = (text as? NSString)?.size(withAttributes: [.font: font!]) ?? .zero |
There was a problem hiding this comment.
Why are you setting this twice?
| @@ -407,6 +407,92 @@ extension URL { | |||
|
|
|||
| return proposedPath | |||
| } | |||
|
|
|||
| public var isLTRRendered: Bool { | |||
There was a problem hiding this comment.
Please place in BraveShared, not Shared (reminder: Shared is a legacy Firefox target we're trying to avoid adding new things to)
Brandon-T
force-pushed
the
bugfix/URL-BarLTR
branch
from
4d09485
to
e471689
Compare
…is works for ALL urls so far. Needs Unit Tests.
Brandon-T
force-pushed
the
bugfix/URL-BarLTR
branch
from
e471689
to
e75aef4
Compare
Address feedback
…text direction and base direction
Brandon-T
force-pushed
the
bugfix/URL-BarLTR
branch
from
e75aef4
to
00a2cc4
Compare
stoletheminerals
approved these changes
Nov 23, 2024
| ) | ||
|
|
||
| // Strip prefixes | ||
| if let range = renderedString.range(of: "^(www|mobile|m)\\.", options: .regularExpression) { |
There was a problem hiding this comment.
doesn't omitTrivialSubdomains above do the same?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#42070 and https://github.com/brave/internal/issues/1228
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: